Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matchms: switch to scores object #256

Closed
hechth opened this issue Apr 21, 2022 · 0 comments · Fixed by #289
Closed

matchms: switch to scores object #256

hechth opened this issue Apr 21, 2022 · 0 comments · Fixed by #289
Assignees

Comments

@hechth
Copy link
Member

hechth commented Apr 21, 2022

Currently, the matchms similarity tool creates 2 tables containing the matches and scores tables - with the newer 2.5d scores arrays that are in progress here and here, it is better to stick with the Scores object also in Galaxy and create tools for plotting, exporting or filtering inside Galaxy as well, creating a set of simpler, modular tools.

This also means changing the input for the matchms formatting tool which currently takes 2 tables as input - this can then directly take a score as input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

2 participants