Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated matchms to 0.27.0 #558

Merged
merged 2 commits into from
Jul 15, 2024
Merged

Updated matchms to 0.27.0 #558

merged 2 commits into from
Jul 15, 2024

Conversation

zargham-ahmad
Copy link
Collaborator

This PR includes the following:

  • updated matchms to 0.27.0
  • removed add_losses from matchms filtering as per the 0.27.0 release note "add_losses() filter was removed. Losses will no longer be stored as part of a Spectrum object, but will be computed on the fly"
  • updated test data for matchms fingerprint similarity

closes #554

@hechth
Copy link
Member

hechth commented Jul 15, 2024

@zargham-ahmad aren't there any other version changes needed regarding the galaxy tool wrapper version in the other matchms tools? Or are they all at 0?

@zargham-ahmad
Copy link
Collaborator Author

@zargham-ahmad aren't there any other version changes needed regarding the galaxy tool wrapper version in the other matchms tools? Or are they all at 0?

they are all at 0

@hechth hechth merged commit 8db07ed into RECETOX:master Jul 15, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hechth hechth hechth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update matchms to 0.27.0
2 participants
@zargham-ahmad @hechth