Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update retention time correction step #209

Closed
4 tasks
hechth opened this issue Jun 16, 2023 · 1 comment · Fixed by #220
Closed
4 tasks

Update retention time correction step #209

hechth opened this issue Jun 16, 2023 · 1 comment · Fixed by #220
Assignees
Labels
enhancement New feature or request

Comments

@hechth
Copy link
Member

hechth commented Jun 16, 2023

Seems like the current RT alignment step doesn't use the computed clusters for the RT correction but again does some clustering or alignment based on tolerances and only uses the sample name.

There are 2 options

  • read the sample name from the files so that we don't need the clustering step
  • actually use the clusters for the RT correction

The rt correction step is just based on establishing matching points ("clusters") between the template and the individual samples and then a smoothed curve over the differences is created and applied to the individual samples.

Steps

@hechth hechth self-assigned this Dec 6, 2023
@hechth hechth removed their assignment Apr 18, 2024
@hechth hechth added the enhancement New feature or request label Apr 18, 2024
@hechth
Copy link
Member Author

hechth commented Jul 11, 2024

We should pass the sample name to the correct time function and the sample name can then be read from the parquet file metadata in the galaxy wrapper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants