Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for the next major version #34

Open
NoahAndrews opened this issue Oct 3, 2024 · 5 comments
Open

Changes for the next major version #34

NoahAndrews opened this issue Oct 3, 2024 · 5 comments

Comments

@NoahAndrews
Copy link
Member

NoahAndrews commented Oct 3, 2024

  • Make sendRtrMessage() accept an expected response length, rather than an array of bytes
@NoahAndrews NoahAndrews changed the title Make sendRtrMessage() accept an expected response length, rather than an array of bytes Changes for the next major version Oct 4, 2024
@LandryNorris
Copy link
Contributor

The command to get elements from #35 should have a buffer field for elements. This will prevent having to write, read, and delete a file in order to get the data, and prevents multiple reads (to get the element metadata, you have to read the element anyways).

@NoahAndrews
Copy link
Member Author

Honestly all DFU parsing functions would be better off in a separate library

@NoahAndrews
Copy link
Member Author

initializeNotifier() should return a handle, and the other notifier functions should accept one.

@NoahAndrews
Copy link
Member Author

NoahAndrews commented Oct 11, 2024

We should remove the concept of registering a device to the HAL from node-can-bridge. That concept is useful in CANBridge, for allowing software written against WPILib to perform CAN communication using this library without having to change their code, but it is not useful here.

@NoahAndrews
Copy link
Member Author

NoahAndrews commented Nov 11, 2024

timeStamp should become timestampMs (or timestampUs if we end up using microseconds in CANBridge), and its type should be bigint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants