When closing a file, "Problems" should be removed

[bersbersbers]

I constantly see linting messages from files which I have already closed. Since there is no way to delete them, I feel it would be sensible to remove them when the file is closed.

See also REditorSupport/vscode-R#376 (comment), #292, microsoft/vscode-python#12630, microsoft/vscode#101885, microsoft/vscode#100646

[bersbersbers]

(This get even worse when you delete a file. You will never get rid of this file's "Problems" until you reload VS Code.

[renkun-ken]

Currently, the diagnostics is only removed when an external file (outside the workspace root) is closed.

The languageserver will load all R files in ./R if the workspace is a package. Does it make sense to you that if the workspace is not a package, then closing a file should remove its diagnostics while if the workspace is a package then closing a file does not remove its diagnostics?

[bersbersbers]

Does it make sense to you that if the workspace is not a package, then closing a file should remove its diagnostics

Yes, for the reasons outlined above: it is how most other extensions operate, and once you delete a file, you are stuck with its "Problems" forever otherwise.

while if the workspace is a package then closing a file does not remove its diagnostics

I am not working on packages, so I can give useful comments only on the non-packages situation. Having said that: I can see how one should have a more holistic view of one's code in this situation: for example, because packages are often shared publicly or even published in repos which have stricter linting requirements than the average coder's collection of scripts. So I would consider this reasonable. But again, my exposure to this situation is pretty much null.

[renkun-ken]

OK, then #349 should work for you. For non-package workspace, when you close a file, it will remove its diagnostics. When you delete the file, the text editor is not necessarily closed. When you close its editor, then its diagnostics will be removed too. Does this sound reasonable to you?

[bersbersbers]

When you delete the file, the text editor is not necessarily closed.

Good point.

When you close its editor, then its diagnostics will be removed too. Does this sound reasonable to you?

Yes, it does.

[renkun-ken]

You could install the latest development version and see if it works for you.