Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completion not working before close parenthesis #410

Closed
renkun-ken opened this issue Apr 4, 2021 · 3 comments · Fixed by #411
Closed

Completion not working before close parenthesis #410

renkun-ken opened this issue Apr 4, 2021 · 3 comments · Fixed by #411

Comments

@renkun-ken
Copy link
Member

renkun-ken commented Apr 4, 2021

Consider the following code

fun <- function(x, y, z) {
  paste0(x, y, z)
}

fun("free"|)

Inserting , at | does not trigger the signature help of fun(x, y, z), and typing e.g. z does not get any completion item. However, no error is observed from the logging of languageserver. Also, replacing "free" to some other strings, the problem might disappear.

@randy3k
Copy link
Member

randy3k commented Apr 5, 2021

It sounds that the issue is the detection of string enclosure.

@renkun-ken
Copy link
Member Author

I revert #276 and it works as before. Therefore, it is certainly caused by a regression in #276.

@randy3k
Copy link
Member

randy3k commented Apr 5, 2021

Thanks for the investigation. I'll take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants