Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle workspace/didChangeWatchedFiles #446

Closed
renkun-ken opened this issue Jul 1, 2021 · 1 comment · Fixed by #447
Closed

Handle workspace/didChangeWatchedFiles #446

renkun-ken opened this issue Jul 1, 2021 · 1 comment · Fixed by #447

Comments

@renkun-ken
Copy link
Member

There are some scenarios where some R files are created, changed, or removed outside editor operations which is not sent from client to server via lsp requests.

  • Git checkout
  • Rcpp/cpp11 generate R wrapper file for exported/registered C++ functions

In these cases, language server is not aware of the changes of the files, and thus will not update the workspace so that symbol definition and etc will not update accordingly until user explicitly open the changed files.

Therefore, we should handle workspace/didChangeWatchedFiles.

@renkun-ken
Copy link
Member Author

For vscode client, it does not watch any files at the moment. We need to update the client options at https://github.com/REditorSupport/vscode-r-lsp/blob/master/src/extension.ts#L93 so that it watches all R files in the workspace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant