Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R6Class finalize() method is public, but it should be private as of R6 2.4.0 #551

Closed
renkun-ken opened this issue May 23, 2022 · 0 comments · Fixed by #553
Closed

R6Class finalize() method is public, but it should be private as of R6 2.4.0 #551

renkun-ken opened this issue May 23, 2022 · 0 comments · Fixed by #553

Comments

@renkun-ken
Copy link
Member

renkun-ken commented May 23, 2022

When the package is installed, it complains about the finalize() method defined by R6 classes with latest R6 2.5.1.9000:

✔  checking for file ‘/Users/ken/Workspaces/github/languageserver/DESCRIPTION’ ...
─  preparing ‘languageserver’: (2.1s)
✔  checking DESCRIPTION meta-information ...
─  cleaning src
─  checking for LF line-endings in source and make files and shell scripts (497ms)
─  checking for empty or unneeded directories
   Removed empty directory ‘languageserver/tests/testthat/_snaps’
─  building ‘languageserver_0.3.12.9000.tar.gz’
   
Running /Library/Frameworks/R.framework/Versions/4.2/Resources/bin/R CMD \
  INSTALL \
  /var/folders/8n/fdyp8ztd42gd2s61p6nzqrgh0000gn/T//RtmpScjVqI/languageserver_0.3.12.9000.tar.gz \
  --install-tests 
* installing to library ‘/Users/ken/Library/R/x86_64/4.2/library’
* installing *source* package ‘languageserver’ ...
** using staged installation
** libs
clang -mmacosx-version-min=10.13 -I"/Library/Frameworks/R.framework/Versions/4.2/Resources/include" -DNDEBUG   -I/usr/local/include   -fPIC  -Wall -g -O2  -c fsm.c -o fsm.o
clang -mmacosx-version-min=10.13 -I"/Library/Frameworks/R.framework/Versions/4.2/Resources/include" -DNDEBUG   -I/usr/local/include   -fPIC  -Wall -g -O2  -c languageserver.c -o languageserver.o
clang -mmacosx-version-min=10.13 -I"/Library/Frameworks/R.framework/Versions/4.2/Resources/include" -DNDEBUG   -I/usr/local/include   -fPIC  -Wall -g -O2  -c reader.c -o reader.o
clang -mmacosx-version-min=10.13 -I"/Library/Frameworks/R.framework/Versions/4.2/Resources/include" -DNDEBUG   -I/usr/local/include   -fPIC  -Wall -g -O2  -c search.c -o search.o
clang -mmacosx-version-min=10.13 -I"/Library/Frameworks/R.framework/Versions/4.2/Resources/include" -DNDEBUG   -I/usr/local/include   -fPIC  -Wall -g -O2  -c stack.c -o stack.o
clang -mmacosx-version-min=10.13 -dynamiclib -Wl,-headerpad_max_install_names -undefined dynamic_lookup -single_module -multiply_defined suppress -L/Library/Frameworks/R.framework/Versions/4.2/Resources/lib -L/usr/local/lib -o languageserver.so fsm.o languageserver.o reader.o search.o stack.o -F/Library/Frameworks/R.framework/Versions/4.2 -framework R -Wl,-framework -Wl,CoreFoundation
installing to /Users/ken/Library/R/x86_64/4.2/library/00LOCK-languageserver/00new/languageserver/libs
** R
** inst
** tests
** byte-compile and prepare package for lazy loading
R6Class LanguageBase: finalize() method is public, but it should be private as of R6 2.4.0. This code will continue to work, but in a future version of R6, finalize() will be required to be private.
R6Class LanguageClient: finalize() method is public, but it should be private as of R6 2.4.0. This code will continue to work, but in a future version of R6, finalize() will be required to be private.
R6Class LanguageServer: finalize() method is public, but it should be private as of R6 2.4.0. This code will continue to work, but in a future version of R6, finalize() will be required to be private.
R6Class Session: finalize() method is public, but it should be private as of R6 2.4.0. This code will continue to work, but in a future version of R6, finalize() will be required to be private.
** help
*** installing help indices
** building package indices
** testing if installed package can be loaded from temporary location
** checking absolute paths in shared objects and dynamic libraries
** testing if installed package can be loaded from final location
** testing if installed package keeps a record of temporary installation path
* DONE (languageserver)
* ```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant