Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide offline methods #22

Closed
zoedberg opened this issue Jul 20, 2023 · 1 comment · Fixed by #23
Closed

provide offline methods #22

zoedberg opened this issue Jul 20, 2023 · 1 comment · Fixed by #23
Labels
enhancement New feature or request
Milestone

Comments

@zoedberg
Copy link
Contributor

The current implementation of Runtime requires a valid electrum_url in order to be loaded. This means that all RGB methods require to be online, even methods that do not have this requirement because they actually use only data saved on disk (e.g. iface_by_name and contract_iface to get asset metadata). I propose to make all methods that do not require a blockchain resolver available even when offline.

I think there are many ways to implement this. One solution could be: making the electrum_url parameter of Runtime::load an optional one, then of course make also the resolver Runtime's' field optional and check for it's presence only on methods that actually need it, returning an error if the Runtime has been instantiated without an electrum URL.

@dr-orlovsky what do you think?

@dr-orlovsky dr-orlovsky added the enhancement New feature or request label Jul 20, 2023
@dr-orlovsky dr-orlovsky added this to the v0.11.0 milestone Jul 20, 2023
@dr-orlovsky
Copy link
Member

Good point, will work on that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants