Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCN Lite: Add "no 8-Bit support" to documentation #8598

Closed
Citrullin opened this issue Feb 19, 2018 · 12 comments · Fixed by #12124
Closed

CCN Lite: Add "no 8-Bit support" to documentation #8598

Citrullin opened this issue Feb 19, 2018 · 12 comments · Fixed by #12124
Labels
Area: network Area: Networking Area: pkg Area: External package ports Community: Hack'n'ACK candidate This PR is a candidate for review and discussion during one of RIOT's monthly Hack'n'ACK parties Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Comments

@Citrullin
Copy link
Contributor

I tried one CCN Lite example. While compiling I got many errors. I fixed some of them, until I reached the following point:

ccnl-pkt-ccntlv.c:508:5: error: left shift count >= width of type [-Werror]

ccntlv line 508

    if ( (unsigned int)len >= ((1 << 16) - sizeof(struct ccnx_tlvhdr_ccnx2015_s)))
        return -1;

Since CCN Lite shifts 16 bits, I guess 8-Bit MCUs are not supported. I recommend to add this somewhere to the documentation. :) There are also other places where CCN Lite shifts 16 bits.

@jnohlgard
Copy link
Member

I guess ccn lite assumes int is 32 bit. This should be fixed upstream, but I guess you should be able to add a cast to uint32_t on the left shift to fix it.

@mfrey
Copy link
Contributor

mfrey commented Feb 20, 2018

CCN-lite lacks precision in the length of types. My assumption is that this is partially due to the fact that it supports multiple message formats. We've already discussed this briefly and it is already an item on a todo list

@Citrullin
Copy link
Contributor Author

Citrullin commented Feb 20, 2018

@mfrey Of course, it would be great to get a fix for it :) But for now, I think a short notice in the documentation is just fine. So, that new User don't need to search for it etc. (just for networking with CCN Lite). :) I think the fix takes a bit more time than writing something into the docu.

@miri64 miri64 added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: network Area: Networking Area: pkg Area: External package ports labels Oct 17, 2018
@PeterKietzmann
Copy link
Member

It's documented here in the ccn-lite FAQ. @Citrullin, @cgundogan would you provide that information in the RIOT doc? I'm adding the Hack'n'ACK label for that.

@PeterKietzmann PeterKietzmann added the Community: Hack'n'ACK candidate This PR is a candidate for review and discussion during one of RIOT's monthly Hack'n'ACK parties label Feb 21, 2019
@stale
Copy link

stale bot commented Aug 25, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions.

@stale stale bot added the State: stale State: The issue / PR has no activity for >185 days label Aug 25, 2019
@miri64 miri64 removed the State: stale State: The issue / PR has no activity for >185 days label Aug 28, 2019
@miri64
Copy link
Member

miri64 commented Aug 28, 2019

Ping @Citrullin @cgundogan?

@Citrullin
Copy link
Contributor Author

Citrullin commented Aug 28, 2019

@miri64 I don't really care about this. Looks like the general interest is not really high.

@cgundogan
Copy link
Member

see cn-uofbasel/ccn-lite#363. Once merged, this issue should resolve.

@miri64
Copy link
Member

miri64 commented Aug 28, 2019

Merged, so I guess all we need now is a version bump of CCN-lite to close this issue ;-).

@miri64
Copy link
Member

miri64 commented Aug 28, 2019

Afair, last time this broke a few things with the shell commands. But I might be wrong.

For this we have testing.

@cgundogan
Copy link
Member

@Citrullin just out of curiosity: which AVR board did you use to compile ccn-lite?

@Citrullin
Copy link
Contributor Author

@Citrullin just out of curiosity: which AVR board did you use to compile ccn-lite?

Some Arduino clone as I remember. Some ATMEGA328P.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: network Area: Networking Area: pkg Area: External package ports Community: Hack'n'ACK candidate This PR is a candidate for review and discussion during one of RIOT's monthly Hack'n'ACK parties Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants