Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArmModeInstruction::DataProcessing has redundancy in the fields #168

Open
AlessioC31 opened this issue Feb 16, 2023 · 0 comments
Open

ArmModeInstruction::DataProcessing has redundancy in the fields #168

AlessioC31 opened this issue Feb 16, 2023 · 0 comments

Comments

@AlessioC31
Copy link
Collaborator

pub enum ArmModeInstruction {
    DataProcessing {
        condition: Condition,
        alu_instruction: ArmModeAluInstruction,
        set_conditions: bool,
        op_kind: OperandKind,
        rn: u32,
        destination: u32,
        op2: AluSecondOperandInfo,
    },
...

We can remove op_kind since it encodes the information about whether the second op is register/immediate, but we already have this information in the op2 field

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant