Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: async http/ws #57

Open
yan-foto opened this issue Aug 17, 2021 · 2 comments
Open

Feature request: async http/ws #57

yan-foto opened this issue Aug 17, 2021 · 2 comments

Comments

@yan-foto
Copy link

Before submitting a PR, I wanted to ask if the maintainers or community are interested in async version of HTTP requests and WebSocket operations (for streams). I have a proof of concept under my fork.
@chrisamin
Copy link
Contributor

Hi,

I would potentially be interested in such a pull request. If you're still willing then please look to base it on the release-1.5.0 branch as I have already converted the upcoming release to use python-socketio.

Note that the async version should be backwards-compatible with the existing sync version.

@yan-foto
Copy link
Author

That sounds good! Have you taken a look at how I do it at the moment? I have two different classes for the legacy and the async stream. Is that ok?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chrisamin @yan-foto