Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make semesters object-oriented #82

Open
ZMYaro opened this issue Feb 1, 2018 · 0 comments
Open

Make semesters object-oriented #82

ZMYaro opened this issue Feb 1, 2018 · 0 comments
Labels

Comments

@ZMYaro
Copy link
Member

ZMYaro commented Feb 1, 2018

This is not something we necessarily have to do; just an idea.

What if instead of having a pile of functions in semesters.py we defined a Semester class that had those functions. Instead of passing floats (or strings or whatever else) around, we would pass Semester objects around, which could handle things like input validation and compensating for floating point errors.

We can discuss further at a future Webmaster Committee meeting.

@ZMYaro ZMYaro added the refactor label Feb 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant