Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement unit tests for telegram.go #307

Open
Tjzabel opened this issue Apr 18, 2020 · 4 comments
Open

Implement unit tests for telegram.go #307

Tjzabel opened this issue Apr 18, 2020 · 4 comments
Labels
blocked Progress blocked by another task or issue new change Adds new capabilities or functionality quality assurance CI tests, unit tests, integration tests, any kind of testing Telegram Issues relating to Telegram bridge
Milestone

Comments

@Tjzabel
Copy link
Member

Tjzabel commented Apr 18, 2020

Summary

Before we write unit tests for the main telegram.go file, we need to determine the method of testing that works best for the scope of this file.

Since telegram.go makes heavy use of external libraries and functionality, we need to have a way to properly mock all of these external calls so we can efficiently test the desired functionality.

@Tjzabel Tjzabel added quality assurance CI tests, unit tests, integration tests, any kind of testing research Research and more data is needed to make a decision Telegram Issues relating to Telegram bridge labels Apr 18, 2020
@Tjzabel Tjzabel added this to the v2.0.0 milestone Apr 18, 2020
@Tjzabel Tjzabel added the new change Adds new capabilities or functionality label Apr 18, 2020
@Tjzabel Tjzabel changed the title Determine best way to test telegram.go Implement unit tests for telegram.go May 9, 2020
@Tjzabel Tjzabel removed the research Research and more data is needed to make a decision label May 9, 2020
@jwflory jwflory modified the milestones: v2.0.0, v2.x.x May 23, 2020
@jwflory
Copy link
Member

jwflory commented May 23, 2020

Discussed in 2020-05-23 meeting.


Release-blocking: No

@kennedy was interested in this work, and since it is not release-blocking, it is okay if this does not make it into the v2.0.0 release. We should revisit this issue in next week's meeting to figure out what next steps are here.

@jwflory jwflory modified the milestones: v2.x.x, v2.0.1 May 24, 2020
@jwflory
Copy link
Member

jwflory commented May 24, 2020

  • Metadata edited:
    • Milestone (v2.x.x ➡️ v2.0.1)

@kennedy kennedy removed their assignment Aug 11, 2020
@jwflory jwflory modified the milestones: v2.0.1, v2.x.x Oct 10, 2020
@jwflory
Copy link
Member

jwflory commented Nov 1, 2020

Discussed in 2020-11-01 IRC/Telegram meeting.


The testing sprint begins! I am taking this one on to get more familiar with the Telegram side of things and to get more comfortable with unit testing. Aiming for completion by end of sprint, 15 November.

@jwflory jwflory self-assigned this Nov 1, 2020
@jwflory jwflory modified the milestones: v2.x.x, v2.1.1 Nov 1, 2020
@jwflory jwflory added the blocked Progress blocked by another task or issue label Nov 16, 2020
@jwflory jwflory removed their assignment Nov 16, 2020
@jwflory
Copy link
Member

jwflory commented Nov 16, 2020

Discussed in 2020-11-15 meeting.


Blocked on #343. @Zedjones mentioned a NodeJS project that runs a local "mocked" Telegram API. We could potentially use this for something closer to integration testing. Since @Zedjones is already looking at GitHub Actions for migrating some of our CI and release automation processes into GitHub Actions, this issue is marked as blocked until the release automation issue is resolved.

See #343 for more info.

@jwflory jwflory removed this from the v2.1.1 milestone Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Progress blocked by another task or issue new change Adds new capabilities or functionality quality assurance CI tests, unit tests, integration tests, any kind of testing Telegram Issues relating to Telegram bridge
Projects
None yet
Development

No branches or pull requests

3 participants