Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HIPIFY][feature] Support for fp8 data types #1617

Open
foreverlms opened this issue Aug 14, 2024 · 2 comments
Open

[HIPIFY][feature] Support for fp8 data types #1617

foreverlms opened this issue Aug 14, 2024 · 2 comments
Assignees
Labels
feature Feature request or implementation

Comments

@foreverlms
Copy link

Problem Description

Such as when I hipify a cu file having fp8 datatype in it, after the hipify-clang command, the fp8 datatype doesn't turned into HIP fp8 type.

For example:

__nv_fp8_e4m3

doesn't change and the hipify-clang will report error:

 error: unknown type name '__nv_fp8_e4m3'

Why? Doesn't hipify support FP8?

Operating System

Ubuntu 20.04.6 LTS (Focal Fossa)

CPU

AMD EPYC 7643 48-Core Processor

ROCm Version

ROCm 6.0.0

ROCm Component

HIPIFY

Steps to Reproduce

No response

(Optional for Linux users) Output of /opt/rocm/bin/rocminfo --support

No response

Additional Information

No response

@emankov emankov self-assigned this Aug 14, 2024
@emankov emankov added the feature Feature request or implementation label Aug 14, 2024
@emankov
Copy link
Collaborator

emankov commented Aug 14, 2024

Hello @foreverlms,

Currently, HIP supports some of the fp8 data types and APIs. Whereas, HIPIFY tools don't. Thank you for pointing it out.

Marking the ticket as a feature to Implement.

@emankov emankov changed the title [HIPIFY]: Does hipify support fp8 data type? [HIPIFY] Support for fp8 data types Aug 14, 2024
@emankov emankov changed the title [HIPIFY] Support for fp8 data types [HIPIFY][feature] Support for fp8 data types Aug 14, 2024
@foreverlms
Copy link
Author

Thanks for replying. Hope to see the fp8 support available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature request or implementation
Projects
None yet
Development

No branches or pull requests

2 participants