Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue]: Dependency on msgpack even when -DTensile_LIBRARY_FORMAT=yaml #1734

Open
trixirt opened this issue Mar 5, 2025 · 2 comments
Open

Comments

@trixirt
Copy link

trixirt commented Mar 5, 2025

Problem Description

tensilelite checks if msgpack can be imported here
https://github.com/ROCm/hipBLASLt/blob/develop/tensilelite/Tensile/LibraryIO.py#L63

but there is no check here
https://github.com/ROCm/hipBLASLt/blob/develop/tensilelite/Tensile/Ops/ExtOpCreateLibrary.py#L27

For distro's without a python msgpack, like RHEL, this is a problem.

Operating System

RHEL 10

CPU

ALL

GPU

AMD Instinct MI210

Other

No response

ROCm Version

ROCm 6.2.3

ROCm Component

No response

Steps to Reproduce

No response

(Optional for Linux users) Output of /opt/rocm/bin/rocminfo --support

No response

Additional Information

The release drop down for issues needs to be updated. the release is 6.3.3

@trixirt
Copy link
Author

trixirt commented Mar 5, 2025

The msgpack package is checked for conditionally here
https://github.com/ROCm/hipBLASLt/blob/develop/tensilelite/Tensile/Source/lib/CMakeLists.txt#L99

but is used unconditionally here
https://github.com/ROCm/hipBLASLt/blob/develop/library/src/amd_detail/hipblaslt-ext-op-internal.hpp#L37

msgpack should be required in the toplevel CMakeLists.txt

@ppanchad-amd
Copy link

Hi @trixirt. Internal ticket has been created to investigate this issue. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants