You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jan 26, 2024. It is now read-only.
I'm maintaining hip package in Gentoo and I found although the cmake https://github.com/ROCm-Developer-Tools/ROCclr/blob/develop/cmake/ROCclrLC.cmake specifies that librocclr.a calls functions in libamd_comgr.so, when it comes to the final link of libamdhip64.so, the linker with --as-needed flag drops the link of libamd_comgr.so, meaning there is no functions in libamd_comgr.so called. I checked that -DUSE_COMGR_LIBRARY is used in compiling.
So is libamdhip really need libcomgr, or building hip just using comgr headers?
The text was updated successfully, but these errors were encountered:
See my comments on the other issue. I don't think you can do this, since comgr is used as a compiler interface. I think the way it calls back to comgr is a bit confusing because it's meant to be more OS/backend generic (ROCclr works on Window's backend too).
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I'm maintaining hip package in Gentoo and I found although the cmake https://github.com/ROCm-Developer-Tools/ROCclr/blob/develop/cmake/ROCclrLC.cmake specifies that librocclr.a calls functions in libamd_comgr.so, when it comes to the final link of libamdhip64.so, the linker with
--as-needed
flag drops the link of libamd_comgr.so, meaning there is no functions in libamd_comgr.so called. I checked that-DUSE_COMGR_LIBRARY
is used in compiling.So is libamdhip really need libcomgr, or building hip just using comgr headers?
The text was updated successfully, but these errors were encountered: