Skip to content

Commit 216ad2d

Browse files
committed
[clang-tidy] Fix bugprone-bad-signal-to-kill-thread crash when SIGTERM is not a literal.
If `SIGTERM` is not a literal (e.g. `#define SIGTERM ((unsigned)15)`) bugprone-bad-signal-to-kill-thread check crashes. Stack dump: ``` #0 0x000000000217d15a llvm::sys::PrintStackTrace(llvm::raw_ostream&) (/llvm-project/build/bin/clang-tidy+0x217d15a) #1 0x000000000217b17c llvm::sys::RunSignalHandlers() (/llvm-project/build/bin/clang-tidy+0x217b17c) #2 0x000000000217b2e3 SignalHandler(int) (/llvm-project/build/bin/clang-tidy+0x217b2e3) #3 0x00007f6a7efb1390 __restore_rt (/lib/x86_64-linux-gnu/libpthread.so.0+0x11390) #4 0x000000000212ac9b llvm::StringRef::getAsInteger(unsigned int, llvm::APInt&) const (/llvm-project/build/bin/clang-tidy+0x212ac9b) #5 0x0000000000593501 clang::tidy::bugprone::BadSignalToKillThreadCheck::check(clang::ast_matchers::MatchFinder::MatchResult const&) (/llvm-project/build/bin/clang-tidy+0x593501) ``` Reviewed By: hokein Differential Revision: https://reviews.llvm.org/D85398
1 parent 8671166 commit 216ad2d

File tree

2 files changed

+12
-0
lines changed

2 files changed

+12
-0
lines changed

clang-tools-extra/clang-tidy/bugprone/BadSignalToKillThreadCheck.cpp

+2
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,8 @@ void BadSignalToKillThreadCheck::check(const MatchFinder::MatchResult &Result) {
3939
return llvm::None;
4040
const MacroInfo *MI = PP->getMacroInfo(It->first);
4141
const Token &T = MI->tokens().back();
42+
if (!T.isLiteral())
43+
return llvm::None;
4244
StringRef ValueStr = StringRef(T.getLiteralData(), T.getLength());
4345

4446
llvm::APInt IntValue;
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
// RUN: clang-tidy %s --checks=-*,bugprone-bad-signal-to-kill-thread -- | count 0
2+
3+
#define SIGTERM ((unsigned)15) // no-crash
4+
using pthread_t = int;
5+
int pthread_kill(pthread_t thread, int sig);
6+
7+
int func() {
8+
pthread_t thread;
9+
return pthread_kill(thread, 0);
10+
}

0 commit comments

Comments
 (0)