Revert "recovering node source from dict (pytorch#158373)"

This reverts commit 4d05598.

Reverted pytorch#158373 on behalf of https://github.com/facebook-github-bot due to Diff reverted internally ([comment](pytorch#158373 (comment)))

Author: pytorchmergebot

test/fx/test_fx_traceback.py

@@ -32,8 +32,6 @@ def test_node_source(self):
             dummy_source_dict,
         )
 
-        self.assertEqual(node_source, NodeSource._from_dict(node_source.to_dict()))
-
         # Dummy node
         node = torch.fx.Node(
             graph=torch.fx.Graph(),
@@ -181,28 +179,14 @@ def forward(self, x):
                     if node_name_1 in same_ancestor_nodes
                     else None,
                 }:
-                    self.assertEqual(
-                        node_name_to_from_node[node_name_1],
-                        node_name_to_from_node[node_name_2],
-                    )
-                    self.assertEqual(
-                        [
-                            NodeSource._from_dict(ns.to_dict())
-                            for ns in node_name_to_from_node[node_name_1]
-                        ],
-                        node_name_to_from_node[node_name_2],
+                    self.assertTrue(
+                        node_name_to_from_node[node_name_1]
+                        == node_name_to_from_node[node_name_2]
                     )
                 else:
-                    self.assertNotEqual(
-                        node_name_to_from_node[node_name_1],
-                        node_name_to_from_node[node_name_2],
-                    )
-                    self.assertNotEqual(
-                        [
-                            NodeSource._from_dict(ns.to_dict())
-                            for ns in node_name_to_from_node[node_name_1]
-                        ],
-                        node_name_to_from_node[node_name_2],
+                    self.assertTrue(
+                        node_name_to_from_node[node_name_1]
+                        != node_name_to_from_node[node_name_2]
                     )
 
         gm = ep.module()

torch/fx/traceback.py

@@ -152,49 +152,6 @@ def _make_hashable(obj):
 
         return hash(_make_hashable(self.to_dict()))
 
-    @classmethod
-    def _from_dict(cls, d: Optional[dict]) -> Optional["NodeSource"]:
-        """
-        Recursively deserialize from_node metadata from dictionary data.
-        It is used to deserialize the from_node field from serialized metadata.
-        Please use contructor NodeSource(node, ...) to create a NodeSource object.
-        """
-        if d is None:
-            return None
-
-        assert isinstance(d, dict), f"Expected a dict, got {type(d)}"
-
-        # Create a NodeSource object directly without going through the constructor
-        # to avoid issues with graph ID and node creation
-        node_source = NodeSource.__new__(NodeSource)
-
-        # Set the basic attributes
-        node_source.pass_name = d.get("pass_name", "")
-
-        # Parse action string back to NodeSourceAction enum list
-        action_str = d.get("action", "")
-        actions = []
-        if action_str:
-            for action_name in action_str.split("+"):
-                if action_name.upper() == "CREATE":
-                    actions.append(NodeSourceAction.CREATE)
-                elif action_name.upper() == "REPLACE":
-                    actions.append(NodeSourceAction.REPLACE)
-        node_source.action = actions
-
-        # Create the NodeInfo object directly
-        if "name" in d and "target" in d and "graph_id" in d:
-            node_info = NodeSource.NodeInfo(
-                d.get("name", ""), d.get("target", ""), d.get("graph_id", -1)
-            )
-            node_source.node_info = node_info
-        else:
-            node_source.node_info = None
-
-        # Recursively deserialize nested from_node
-        node_source.from_node = [cls._from_dict(fn) for fn in d.get("from_node", [])]
-        return node_source
-
 
 @compatibility(is_backward_compatible=False)
 @contextmanager