Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable rocprof (v1) support for MI300 profiling #388

Closed
coleramos425 opened this issue Jul 29, 2024 · 0 comments · Fixed by #391 or #392
Closed

Enable rocprof (v1) support for MI300 profiling #388

coleramos425 opened this issue Jul 29, 2024 · 0 comments · Fixed by #391 or #392
Assignees
Labels
enhancement New feature or request Profiling Related to the profiling done in Omniperf

Comments

@coleramos425
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Currently, Omniperf requires the user set export ROCPROF=rocprofv2 to profile on MI300 skews. Per internal conversation with the rocprofiler team, rocprof (v1) has been fully tested and verified for MI300 profiling. I suggest we relax the requirement in Omniperf such that users can profile with rocprof (v1) in addition to rocprofv2.

Describe the solution you'd like
I see the following steps as required:

  1. Make appropriate changes to Omniperf backend. Start with modifying set_compatible_profilers() for each gfx94x child class.
  2. Verify changes on MI300 hardware, ensuring profiling goes smoothly in rocprofv1 environment.
  3. File PR into dev branch
  4. Update documentation PR with a comment instructing @peterjunpark to update core-install.rst accordingly
  5. Update internal ticket to notify all watchers of new change

Additional context
Related GitHub convo to make this change: #362 (comment)
Internal tracking: https://ontrack-internal.amd.com/browse/SWDEV-475098

@coleramos425 coleramos425 added enhancement New feature or request Profiling Related to the profiling done in Omniperf labels Jul 29, 2024
This was linked to pull requests Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Profiling Related to the profiling done in Omniperf
Projects
None yet
2 participants