Merge pull request #6 from tensorflow/master

Stay up to date

Author: AdityaKane2001

.github/bot_config.yml

@@ -21,6 +21,7 @@ assignees:
 # A list of assignees for compiler folder
 compiler_assignees:
    - joker-eph
+   - sanjoy
 # filesystem path
 filesystem_path:
    - tensorflow/c/experimental/filesystem

RELEASE.md

@@ -4,6 +4,13 @@
 
 ## Breaking Changes
 
+* `tf.train.experimental.enable_mixed_precision_graph_rewrite` is removed, as
+  the API only works in graph mode and is not customizable. The function is
+  still accessible under
+  `tf.compat.v1.mixed_precision.enable_mixed_precision_graph_rewrite`, but it is
+  recommended to use the
+  [Keras mixed precision API](https://www.tensorflow.org/guide/mixed_precision)
+  instead.
 *<DOCUMENT BREAKING CHANGES HERE>
 *<THIS SECTION SHOULD CONTAIN API, ABI AND BEHAVIORAL BREAKING CHANGES>
 
@@ -41,12 +48,25 @@
         lower overall memory usage, and a cleaner API. It does not require
         specifying a `delete_key` and `empty_key` that cannot be inserted into
         the table.
+   *    Added support for specifying number of subdivisions in all reduce host
+        collective. This parallelizes work on CPU and speeds up the collective
+        performance. Default behavior is unchanged.
 *   `tf.data`:
     *   Promoting `tf.data.experimental.get_single_element` API to
         `tf.data.Dataset.get_single_element` and deprecating the experimental
         endpoint.
-*  `tf.lite`:
-  * Fix mean op reference quantization rounding issue.
+    *   Promoting `tf.data.experimental.group_by_window` API to
+        `tf.data.Dataset.group_by_window` and deprecating the experimental
+        endpoint.
+    *   Added `stop_on_empty_dataset` parameter to `sample_from_datasets` and
+        `choose_from_datasets`. Setting `stop_on_empty_dataset=True` will stop
+        sampling if it encounters an empty dataset. This preserves the sampling
+        ratio throughout training. The prior behavior was to continue sampling,
+        skipping over exhausted datasets, until all datasets are exhausted. By
+        default, the original behavior (`stop_on_empty_dataset=False`) is
+        preserved.
+*   `tf.lite`:
+    *   Fix mean op reference quantization rounding issue.
 
 ## Thanks to our Contributors
 

tensorflow/BUILD

@@ -791,6 +791,7 @@ package_group(
         "//learning/lib/ami/simple_ml/...",
         "//tensorflow/...",
         "//tensorflow_decision_forests/...",
+        "//tensorflow_federated/...",
         "//third_party/cloud_tpu/inference_converter/...",
     ],
 )

tensorflow/c/BUILD

@@ -5,6 +5,7 @@ load("//tensorflow/core/platform:rules_cc.bzl", "cc_library")
 load(
     "//tensorflow:tensorflow.bzl",
     "check_deps",
+    "if_google",
     "tf_cc_test",
     "tf_copts",
     "tf_cuda_library",
@@ -723,6 +724,7 @@ tf_cc_test(
         "testdata/tf_record",
         "//tensorflow/c/experimental/stream_executor/test:test_pluggable_device.so",
     ],
+    extra_copts = if_google(["-DTENSORFLOW_NO_SHARED_OBJECTS=1"]),
     linkopts = select({
         "//tensorflow:macos": ["-headerpad_max_install_names"],
         "//conditions:default": [],

tensorflow/c/eager/BUILD

@@ -263,7 +263,7 @@ tf_cuda_cc_test(
     srcs = [
         "gradients_test.cc",
     ],
-    args = ["--heap_check=local"],
+    args = ["--heap_check="],
     linkstatic = tf_kernel_tests_linkstatic(),
     tags = tf_cuda_tests_tags() + ["nomac"],
     deps = [
@@ -300,7 +300,7 @@ tf_cuda_cc_test(
     srcs = [
         "unified_api_test.cc",
     ],
-    args = ["--heap_check=local"],
+    args = ["--heap_check="],
     linkstatic = tf_kernel_tests_linkstatic(),
     tags = tf_cuda_tests_tags() + ["no_cuda_asan"],  # b/173654156
     deps = [
@@ -344,7 +344,7 @@ tf_cuda_cc_test(
     srcs = [
         "gradient_checker_test.cc",
     ],
-    args = ["--heap_check=local"],
+    args = ["--heap_check="],
     linkstatic = tf_kernel_tests_linkstatic(),
     tags = tf_cuda_tests_tags() + [
         "no_cuda_asan",  # b/175330074
@@ -715,7 +715,7 @@ tf_cuda_cc_test(
         "c_api_remote_test.cc",
     ],
     # TODO(b/136478427): Figure out how to correctly shut the server down
-    args = ["--heap_check=local"],
+    args = ["--heap_check="],
     tags = [
         "no_windows",
     ],
@@ -747,7 +747,7 @@ tf_cuda_cc_test(
         "c_api_remote_function_test.cc",
     ],
     # TODO(b/136478427): Figure out how to correctly shut the server down
-    args = ["--heap_check=local"],
+    args = ["--heap_check="],
     tags = [
         "no_windows",
     ],
@@ -765,7 +765,7 @@ tf_cuda_cc_test(
         "c_api_distributed_test.cc",
     ],
     # TODO(b/136478427): Figure out how to correctly shut the server down
-    args = ["--heap_check=local"],
+    args = ["--heap_check="],
     tags = [
         "no_windows",
         "noasan",  # leaks gRPC server instances
@@ -798,7 +798,7 @@ tf_cuda_cc_test(
         "c_api_cluster_test.cc",
     ],
     # TODO(b/136478427): Figure out how to correctly shut the server down
-    args = ["--heap_check=local"],
+    args = ["--heap_check="],
     tags = [
         "no_windows",
     ],
@@ -904,7 +904,7 @@ tf_cuda_cc_test(
     srcs = [
         "c_api_experimental_test.cc",
     ],
-    args = ["--heap_check=local"],
+    args = ["--heap_check="],
     linkstatic = tf_kernel_tests_linkstatic(),
     tags = tf_cuda_tests_tags() + ["nomac"],
     deps = [
@@ -927,7 +927,7 @@ tf_cuda_cc_test(
     srcs = [
         "c_api_unified_experimental_test.cc",
     ],
-    args = ["--heap_check=local"],
+    args = ["--heap_check="],
     linkstatic = tf_kernel_tests_linkstatic(),
     tags = tf_cuda_tests_tags() + ["nomac"],
     deps = [

tensorflow/c/eager/abstract_tensor_handle.h

@@ -29,7 +29,7 @@ class AbstractTensorHandle : public core::RefCounted {
  protected:
   enum AbstractTensorHandleKind { kGraph, kMlir, kEager, kTfrt, kCustomDevice };
   explicit AbstractTensorHandle(AbstractTensorHandleKind kind) : kind_(kind) {}
-  virtual ~AbstractTensorHandle() {}
+  ~AbstractTensorHandle() override {}
 
  public:
   // Returns tensor dtype.

tensorflow/c/eager/c_api.cc

@@ -146,7 +146,9 @@ TFE_Context* TFE_NewContext(const TFE_ContextOptions* opts, TF_Status* status) {
       static_cast<tensorflow::ContextDevicePlacementPolicy>(
           opts->device_placement_policy),
       opts->async, device_mgr.release(),
-      /*device_mgr_owned*/ true, r);
+      /*device_mgr_owned*/ true, r,
+      /*cluster_flr=*/nullptr,
+      /*run_eager_op_as_function=*/opts->run_eager_op_as_function);
 #if !defined(IS_MOBILE_PLATFORM)
   eager_context->SetDistributedManager(
       std::make_unique<tensorflow::EagerContextDistributedManager>(

tensorflow/c/eager/c_api_internal.h

@@ -34,6 +34,8 @@ struct TFE_ContextOptions {
       TFE_DEVICE_PLACEMENT_SILENT};
   // If true, use TFRT backend
   bool use_tfrt = false;
+  // Whether to run elementary eager ops wrapped in a call op.
+  bool run_eager_op_as_function = false;
 };
 
 #endif  // TENSORFLOW_C_EAGER_C_API_INTERNAL_H_

tensorflow/c/eager/parallel_device/BUILD

@@ -149,7 +149,7 @@ tf_cc_test(
     srcs = ["parallel_device_remote_test.cc"],
     # TODO(b/136478427): Enable global heap checking when servers shut down
     # cleanly.
-    args = ["--heap_check=local"],
+    args = ["--heap_check="],
     deps = [
         ":parallel_device",
         ":parallel_device_testlib",

tensorflow/c/experimental/gradients/BUILD

@@ -119,7 +119,7 @@ tf_cuda_cc_test(
     srcs = [
         "custom_gradient_test.cc",
     ],
-    args = ["--heap_check=local"],  # TODO(b/174752220): Remove
+    args = ["--heap_check="],  # TODO(b/174752220): Remove
     linkstatic = tf_kernel_tests_linkstatic(),
     tags = tf_cuda_tests_tags(),
     deps = [
@@ -176,7 +176,7 @@ tf_cuda_cc_test(
     srcs = [
         "nn_grad_test.cc",
     ],
-    args = ["--heap_check=local"],  # TODO(b/174752220): Remove
+    args = ["--heap_check="],  # TODO(b/174752220): Remove
     linkstatic = tf_kernel_tests_linkstatic(),
     tags = tf_cuda_tests_tags() + ["no_cuda_asan"],  # b/173654156,
     deps = [
@@ -203,7 +203,7 @@ tf_cuda_cc_test(
     srcs = [
         "math_grad_test.cc",
     ],
-    args = ["--heap_check=local"],  # TODO(b/174752220): Remove
+    args = ["--heap_check="],  # TODO(b/174752220): Remove
     linkstatic = tf_kernel_tests_linkstatic(),
     tags = tf_cuda_tests_tags() + ["no_cuda_asan"],  # b/173654156,
     deps = [
@@ -230,7 +230,7 @@ tf_cuda_cc_test(
     srcs = [
         "array_grad_test.cc",
     ],
-    args = ["--heap_check=local"],  # TODO(b/174752220): Remove
+    args = ["--heap_check="],  # TODO(b/174752220): Remove
     linkstatic = tf_kernel_tests_linkstatic(),
     tags = tf_cuda_tests_tags() + ["no_cuda_asan"],  # b/173654156,
     deps = [