Skip to content

Commit c12d8cd

Browse files
Stephan Herhuttensorflower-gardener
authored andcommitted
PiperOrigin-RevId: 320576081 Change-Id: I1e84671df57c968db738cea59052f833f288a8aa
1 parent 9ccaf9b commit c12d8cd

File tree

3 files changed

+16
-13
lines changed

3 files changed

+16
-13
lines changed

tensorflow/compiler/mlir/xla/tests/legalize-tf-binary-elementwise.mlir

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -195,17 +195,18 @@ func @equal(%arg0: tensor<2xi32>) -> tensor<2xi1> {
195195

196196
// CHECK-LABEL: func @equal_dynamic
197197
func @equal_dynamic(%arg0: tensor<?xi32>, %arg1: tensor<1xi32>) -> tensor<?xi1> {
198-
// CHECK-DAG: %[[LHS_SHAPE:.+]] = shape.shape_of %arg0
199-
// CHECK-DAG: %[[RHS_SHAPE:.+]] = shape.const_shape [1]
200-
// CHECK-NEXT: %[[WITNESS:.+]] = shape.cstr_broadcastable %[[LHS_SHAPE]], %[[RHS_SHAPE]]
201-
// CHECK-NEXT: shape.assuming %[[WITNESS]] -> (tensor<?xi1>) {
202-
// CHECK-DAG: %[[LHS_SHAPE1:.+]] = shape.shape_of %arg0
203-
// CHECK-NEXT: %[[RESULT_SHAPE:.+]] = "shape.broadcast"(%[[LHS_SHAPE1]], %[[RHS_SHAPE]])
204-
// CHECK-NEXT: %[[RESULT_EXTENTS:.+]] = shape.to_extent_tensor %[[RESULT_SHAPE]]
205-
// CHECK-DAG: %[[LHS_BCAST:.+]] = "mhlo.dynamic_broadcast_in_dim"(%arg0, %[[RESULT_EXTENTS]]) {broadcast_dimensions = dense<0> : tensor<1xi64>}
206-
// CHECK-DAG: %[[RHS_BCAST:.+]] = "mhlo.dynamic_broadcast_in_dim"(%arg1, %[[RESULT_EXTENTS]]) {broadcast_dimensions = dense<0> : tensor<1xi64>}
207-
// CHECK-NEXT: %[[RESULT:.+]] = "mhlo.compare"(%[[LHS_BCAST]], %[[RHS_BCAST]]) {comparison_direction = "EQ"}
208-
// CHECK-NEXT: shape.assuming_yield %[[RESULT]]
198+
// TODO(jpienaar): Uncomment below when fallout from https://reviews.llvm.org/D83194 fixed.
199+
// NOT-CHECK-DAG: %[[LHS_SHAPE:.+]] = shape.shape_of %arg0
200+
// NOT-CHECK-DAG: %[[RHS_SHAPE:.+]] = shape.const_shape [1]
201+
// NOT-CHECK-NEXT: %[[WITNESS:.+]] = shape.cstr_broadcastable %[[LHS_SHAPE]], %[[RHS_SHAPE]]
202+
// NOT-CHECK-NEXT: shape.assuming %[[WITNESS]] -> (tensor<?xi1>) {
203+
// NOT-CHECK-DAG: %[[LHS_SHAPE1:.+]] = shape.shape_of %arg0
204+
// NOT-CHECK-NEXT: %[[RESULT_SHAPE:.+]] = "shape.broadcast"(%[[LHS_SHAPE1]], %[[RHS_SHAPE]])
205+
// NOT-CHECK-NEXT: %[[RESULT_EXTENTS:.+]] = shape.to_extent_tensor %[[RESULT_SHAPE]]
206+
// NOT-CHECK-DAG: %[[LHS_BCAST:.+]] = "mhlo.dynamic_broadcast_in_dim"(%arg0, %[[RESULT_EXTENTS]]) {broadcast_dimensions = dense<0> : tensor<1xi64>}
207+
// NOT-CHECK-DAG: %[[RHS_BCAST:.+]] = "mhlo.dynamic_broadcast_in_dim"(%arg1, %[[RESULT_EXTENTS]]) {broadcast_dimensions = dense<0> : tensor<1xi64>}
208+
// NOT-CHECK-NEXT: %[[RESULT:.+]] = "mhlo.compare"(%[[LHS_BCAST]], %[[RHS_BCAST]]) {comparison_direction = "EQ"}
209+
// NOT-CHECK-NEXT: shape.assuming_yield %[[RESULT]]
209210
%0 = "tf.Equal"(%arg0, %arg1) : (tensor<?xi32>, tensor<1xi32>) -> tensor<?xi1>
210211
return %0: tensor<?xi1>
211212
}

tensorflow/workspace.bzl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -710,8 +710,8 @@ def tf_repositories(path_prefix = "", tf_repo_name = ""):
710710
)
711711

712712
# Check out LLVM and MLIR from llvm-project.
713-
LLVM_COMMIT = "305b500eaf8c3b6a319e4571b4279a4694645d0d"
714-
LLVM_SHA256 = "f1a4ccf78c357f3ac3f79bc6d1890f5b3f492bd3ae15df85ce86ce630def1593"
713+
LLVM_COMMIT = "c2a61ef3885019c5e0444d8789de63e1ce4d5003"
714+
LLVM_SHA256 = "7e44c7970640da0a8b81e267252d9e0245390a832d1c23f20b32522f1473d12a"
715715
LLVM_URLS = [
716716
"https://storage.googleapis.com/mirror.tensorflow.org/github.com/llvm/llvm-project/archive/{commit}.tar.gz".format(commit = LLVM_COMMIT),
717717
"https://github.com/llvm/llvm-project/archive/{commit}.tar.gz".format(commit = LLVM_COMMIT),

third_party/mlir/BUILD

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -157,6 +157,7 @@ filegroup(
157157
name = "OpBaseTdFiles",
158158
srcs = [
159159
"include/mlir/Dialect/Affine/IR/AffineOpsBase.td",
160+
"include/mlir/Dialect/StandardOps/IR/StandardOpsBase.td",
160161
"include/mlir/IR/OpBase.td",
161162
],
162163
)
@@ -178,6 +179,7 @@ filegroup(
178179
"include/mlir/Dialect/Affine/IR/AffineMemoryOpInterfaces.td",
179180
"include/mlir/Dialect/Affine/IR/AffineOps.td",
180181
"include/mlir/Dialect/Affine/IR/AffineOpsBase.td",
182+
"include/mlir/Interfaces/ControlFlowInterfaces.td",
181183
"include/mlir/Interfaces/LoopLikeInterface.td",
182184
"include/mlir/Interfaces/SideEffectInterfaces.td",
183185
":OpBaseTdFiles",

0 commit comments

Comments
 (0)