Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Regression] [macOS] Build failure after #14065 #14067

Closed
shinra-electric opened this issue Jun 22, 2023 · 6 comments
Closed

[Regression] [macOS] Build failure after #14065 #14067

shinra-electric opened this issue Jun 22, 2023 · 6 comments

Comments

@shinra-electric
Copy link
Contributor

Quick summary

Build fails on RSX/VK/vkutils/sync.cpp after #14065

Details

No response

Build with regression

#14065

Attach two log files

RPCS3 00cca7b (Success).txt
RPCS3 715e385 (Fail).txt

Attach capture files for visual issues

No response

System configuration

M1 MBP

Other details

No response

@kd-11
Copy link
Contributor

kd-11 commented Jun 22, 2023

Ok, I checked the clang support for the "parenthesized initialization of aggregates" feature and it shows as supported in clang16.
I'm guessing xcode is just too outdated here and doesn't actually support c++20

@kd-11
Copy link
Contributor

kd-11 commented Jun 22, 2023

Also, you may want to try -std=c++20 instead of gnu++20

@shinra-electric
Copy link
Contributor Author

Xcode supports up to C++23, though I don't know if it supports every feature.

Here is a list for your reference.

As far as I remember, the CI uses Xcode 14.0.

@kd-11
Copy link
Contributor

kd-11 commented Jun 22, 2023

From that list it seems to not support the feature. But the CI version would also not work in that case. I hate that apple only shows what they support instead of a feature matrix including what they don't support. Clang however has this at https://clang.llvm.org/cxx_status.html
The section that is making the build fail is "parenthesized initialization of aggregates". We can work around it by replacing the construction with an initializer list.

@shinra-electric
Copy link
Contributor Author

I'm not able to install Xcode 14.3.1 to test, since I'm on macOS 14 and it won't run.

If you'd like I'll close this issue for now, and will re-open if it's still a problem once Xcode 15 gets out of beta. (Or if someone else on Xcode 14 can confirm it's not working there either).

@kd-11
Copy link
Contributor

kd-11 commented Jun 22, 2023

#14070 should fix this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants