Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON macro functions will behave incorrectly if function is not found #1206

Closed
cwisniew opened this issue Jan 28, 2020 · 1 comment
Closed

JSON macro functions will behave incorrectly if function is not found #1206

cwisniew opened this issue Jan 28, 2020 · 1 comment
Labels
bug macro changes This issue adds or changes macro functions. Extra work is required (testing, wiki, code editor) tested This issue has been QA tested by someone other than the developer.

Comments

@cwisniew
Copy link
Member

Describe the bug
The json function code returns null if the function is not found. This should throw an exception with a valid error message. Currently neither of these will occur but the exception should be put in place to catch any problems with future edits.
@cwisniew cwisniew mentioned this issue Jan 28, 2020
Merged
@Phergus Phergus added the bug label Jan 28, 2020
@Phergus Phergus added the macro changes This issue adds or changes macro functions. Extra work is required (testing, wiki, code editor) label Jan 28, 2020
@Phergus Phergus added the tested This issue has been QA tested by someone other than the developer. label Feb 6, 2020
@Phergus
Copy link
Contributor

Phergus commented Feb 6, 2020

Tested. Now reports when an unknown function is passed, e.g. json.nosuchfunction().

@Phergus Phergus closed this as completed Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug macro changes This issue adds or changes macro functions. Extra work is required (testing, wiki, code editor) tested This issue has been QA tested by someone other than the developer.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cwisniew @Phergus