Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Tests for ImageUtils #1325

Closed
amccarthy1 opened this issue Feb 26, 2020 · 2 comments
Closed

Add Tests for ImageUtils #1325

amccarthy1 opened this issue Feb 26, 2020 · 2 comments
Assignees
@amccarthy1
Labels
code-maintenance Adding/editing javadocs, unit tests, formatting. feature Adding functionality that adds value

Comments

@amccarthy1
Copy link
Contributor

Is your feature request related to a problem? Please describe.
I noticed that some of the code in ImageUtils is not covered by tests and would be interested in writing some to get started.

Describe the solution you'd like
I would like for the methods within ImageUtils to have enough coverage to prevent some regressions.

Describe alternatives you've considered
I also considered refactoring/optimizing some parts of these utils, but given that there are no tests, I thought adding tests would be more valuable first.

Additional context
I'm new to this project! I'm mostly looking for ways to get started that will help me understand the codebase.
@amccarthy1
Copy link
Contributor Author

I have started working on this already with #1324

@Phergus Phergus added feature Adding functionality that adds value code-maintenance Adding/editing javadocs, unit tests, formatting. labels Feb 26, 2020
@amccarthy1 amccarthy1 mentioned this issue Feb 26, 2020
Merged
@Phergus
Copy link
Contributor

Phergus commented Mar 5, 2020

No adverse effects seen. Closing.

@Phergus Phergus closed this as completed Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amccarthy1 amccarthy1

Labels
code-maintenance Adding/editing javadocs, unit tests, formatting. feature Adding functionality that adds value
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amccarthy1 @Phergus