Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When changing the vision setting, token must be moved to trigger vision reveal #213

Closed
Azhrei opened this issue Nov 19, 2018 · 8 comments
Closed
Assignees
Labels
bug low Low priority bug/enhancement

Comments

@Azhrei
Copy link
Member

Azhrei commented Nov 19, 2018

Assume a campaign with two (or more) vision types defined. Changing from one to the other does not reveal the new visible range to the player unless the token is moved. Changing the vision field in the token editor should trigger an immediate reveal.

@JamzTheMan JamzTheMan added bug up for grabs Minimal context and are well-suited for new contributors low Low priority bug/enhancement 1 labels Mar 16, 2019
@Merudo
Copy link
Member

Merudo commented Aug 16, 2019

Changing the light source also has the same effect. The FoW is only revealed after movement.

I was wondering, maybe there are some benefits to keeping the current system? If the GM or player picks the wrong vision type or light, they have the chance to change it back before it reveals any FoW.

@Phergus
Copy link
Contributor

Phergus commented Aug 16, 2019

@Azhrei , @aliasmask , @JamzTheMan , @Jaggeroth @rkathey

Any thoughts on Merudo's comment?

@Phergus Phergus removed the up for grabs Minimal context and are well-suited for new contributors label Aug 16, 2019
@aliasmask
Copy link

aliasmask commented Aug 16, 2019

I think I agree with @Merudo to keep our options open. IMO, there's no need to reveal FoW on vision change since players can hit ctrl-i or use the exposeFoW() function if in a macro. Same with a light change.

@Azhrei
Copy link
Member Author

Azhrei commented Aug 16, 2019

Agreed. It’s more flexible to do things in small pieces under macro control. Maybe an argument could be made for adding a parameter that causes FOW to be exposed automatically if options like Allow Players you reveal is set, but I don’t see the need for it.

@Phergus
Copy link
Contributor

Phergus commented Aug 17, 2019

So it seems that the consensus is that changing the sight type, either via macro or Edit Token dialog, should not cause an automatic exposure. That should be left to the calling macro or the person manually changing the sight type to do an exposure.

Would (should?) the same rule apply to changing lights on a token?

@dorpond
Copy link

dorpond commented Aug 17, 2019

I’d say keep consistent, because it would only confuse otherwise.

I personally don’t ever use auto expose; as a DM, I want that granular power, but if I did play with autoexposure, I wouldn’t want my players changing vision/lighting and getting immediate results. Seems too trigger happy for spoiler reveal.

But then again, Maptool wasn’t just built for a specific gaming system - Trevor had a system agnostic approach with Maptool - he wanted someone to be able to play cards, board games, and at one point when he was designing comic vision, how cool it would be If there was a video game style robot team one vs robot team two, where their conic vision would be rotated by the player, showing him the battle field in real time, as he rotated it.

So yeah, it is hard to think outside our own play style box- my box being D&D and me being in control.

Honestly, I don’t know how autoexposure should work. Maybe a public poll, on our social media sites, as well as our forum?

I also don’t use initiative token lock (when it’s not my turn). Are tokens locked for macro use and editing? Might want to keep that feature in mind when changing whatever stuff you change.

Hope this rambling helps some.

@aliasmask
Copy link

Preference setting? Expose FoW on Token Sight/Light Change? I would be okay with that.

@Phergus
Copy link
Contributor

Phergus commented Aug 20, 2019

Closing this issue with everything how it stands currently:

Server Running
Token as PC and NPC

{
  "individual views": 1,
  "players can reveal": 1,
  "auto reveal on movement": 1,
  "strict token management": 1,
  "individual fow": 0
}

Edit Token Dialog
Changing Sight Type - No auto exposure
Changing Has Sight - No auto exposure

Right-Click Menu
Setting Light On - No auto exposure

Via Macro
Setting Light On - No auto exposure
Changing Sight Type - No auto exposure
Changing Has Sight - No auto exposure

If we want to add a preference setting for this or change behavior a ticket should be opened for the next release.

@Phergus Phergus closed this as completed Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug low Low priority bug/enhancement
Projects
None yet
Development

No branches or pull requests

6 participants