Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactoring]: Update to google format 1.16 for spotless formatting #3988

Closed
cwisniew opened this issue Apr 22, 2023 · 1 comment · Fixed by #3989
Closed

[Refactoring]: Update to google format 1.16 for spotless formatting #3988

cwisniew opened this issue Apr 22, 2023 · 1 comment · Fixed by #3989
Assignees
Labels
code-maintenance Adding/editing javadocs, unit tests, formatting.

Comments

@cwisniew
Copy link
Member

Describe the problem

The develop branch has been updated to google format version 1.16, but with release still at 1.11 it makes merges more difficult due to formatting differences.

The improvement you'd like to see

Update google java format for spotless to 1.16 on release-1.13 branch

Expected Benefits

Easier to merge back to develop

Additional Context

Develop branch had to move to an updated version of google format as 1.11 does not work with java 20

@cwisniew cwisniew added the code-maintenance Adding/editing javadocs, unit tests, formatting. label Apr 22, 2023
@cwisniew cwisniew self-assigned this Apr 22, 2023
@kwvanderlinde kwvanderlinde moved this from Todo to Needs Testing in MapTool 1.13.0 May 25, 2023
@kwvanderlinde
Copy link
Collaborator

Given the many PRs that have successfully passed since this change, and the agreement in formatting between release-1.13 and develop, this change checks out.

@github-project-automation github-project-automation bot moved this from Needs Testing to Merged in MapTool 1.13.0 Jul 18, 2023
@kwvanderlinde kwvanderlinde moved this from Merged to Done in MapTool 1.13.0 Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-maintenance Adding/editing javadocs, unit tests, formatting.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants