Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Gradle 8.1 does not completely support Java 20 leading to build failures with certain configurations #4251

Closed
cwisniew opened this issue Aug 16, 2023 · 2 comments · Fixed by #4252
Assignees
Labels

Comments

@cwisniew
Copy link
Member

Describe the Bug

Gradle 8.1 does not completely support java 20 (you can compile Java 20 code but you can also encounter errors if you try to use java 20 to run the build process).

Building generally works, but if you make changes to the .proto files depending on your set up you may get a message saying that java 20 is not supported in gradle 8.1.

To Reproduce

It might be harder to reproduce than avoid

Expected Behaviour

It should just work

Screenshots

No response

MapTool Info

1.14.x

Desktop

Seen it on windows only but cant rule out other OS as well

Additional Context

No response

@cwisniew cwisniew added the bug label Aug 16, 2023
@cwisniew cwisniew self-assigned this Aug 16, 2023
@kwvanderlinde
Copy link
Collaborator

The thing I usually run into is the spotless check failing. In that case, I just get shown the error about having the wrong Java version. But if the check passes, everything works with no mention of a bad Java version. It's quite odd.

@cwisniew
Copy link
Member Author

The thing I usually run into is the spotless check failing. In that case, I just get shown the error about having the wrong Java version. But if the check passes, everything works with no mention of a bad Java version. It's quite odd.

Hmmm I just checked that, I have modified my IDE arguments so run is "spotlessApply run" so wasn't running into it (yes I was tired of having to do another commit for spotless fixes :) ). Its still an issue with 8.2, probably something we have to look at spotless for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants