Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicated Initiative info from getInfo("server"). #739

Closed
Phergus opened this issue Sep 23, 2019 · 2 comments
Closed

Remove duplicated Initiative info from getInfo("server"). #739

Phergus opened this issue Sep 23, 2019 · 2 comments
Assignees
@xdy
Labels
bug low Low priority bug/enhancement macro changes This issue adds or changes macro functions. Extra work is required (testing, wiki, code editor) tested This issue has been QA tested by someone other than the developer.

Comments

@Phergus
Copy link
Contributor

Phergus commented Sep 23, 2019

Describe the bug
initiative owner permissions and initiative movement locked are both in the info returned by getInfo("campaign") making returning initiative owner permissions in getInfo("server") redundant and it isn't a configuration set on the Start Server dialog.

Should be removed.

To Reproduce
Steps to reproduce the behavior:

  1. Run getInfo("campaign") and see both initiative settings in the result.
  2. Run getInfo("server") and see just initiative owner permissions.

Expected behavior
Only needed in one place. Remove from server info.

MapTool Info

  • Version: 1.5.4
  • Install: Any

Desktop (please complete the following information):

  • OS: Windows
  • Version: 10

Additional context
See discussion in #738
@Phergus Phergus added bug low Low priority bug/enhancement documentation needed Missing, out-of-date or bad documentation macro changes This issue adds or changes macro functions. Extra work is required (testing, wiki, code editor) labels Sep 23, 2019
@xdy xdy mentioned this issue Dec 9, 2019
Merged
@xdy
Copy link
Collaborator

xdy commented Dec 9, 2019

My PR #980 should fix this.

@Phergus Phergus added tested This issue has been QA tested by someone other than the developer. and removed documentation needed Missing, out-of-date or bad documentation labels Dec 13, 2019
@Phergus
Copy link
Contributor Author

Phergus commented Dec 13, 2019

Tested. initiative owner permissions no longer included in server info.

@Phergus Phergus closed this as completed Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xdy xdy

Labels
bug low Low priority bug/enhancement macro changes This issue adds or changes macro functions. Extra work is required (testing, wiki, code editor) tested This issue has been QA tested by someone other than the developer.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xdy @Phergus