Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: Toggle display Text Labels on/off #891

Closed
Phergus opened this issue Nov 11, 2019 · 6 comments
Closed

Feature Request: Toggle display Text Labels on/off #891

Phergus opened this issue Nov 11, 2019 · 6 comments
Assignees
@cwisniew
Labels
feature Adding functionality that adds value macro changes This issue adds or changes macro functions. Extra work is required (testing, wiki, code editor) tested This issue has been QA tested by someone other than the developer.

Comments

@Phergus
Copy link
Contributor

Phergus commented Nov 11, 2019

Is your feature request related to a problem? Please describe.
I like to use the text labels an my maps. They are quick and easy to handle und they are readable independently of the zoom level. Sadly, this is also the main issue. If you zoom out, this labels can cover whole parts of the map.

Describe the solution you'd like
I would like to see an option to hide/show text labels on the map. This could work like the options to hide/show grid or coordinates on the menu.

Additional context
Requested by Purzelkater on forums:
https://forums.rptools.net/viewtopic.php?f=26&t=28434
@Phergus Phergus added the feature Adding functionality that adds value label Nov 11, 2019
@Phergus
Copy link
Contributor Author

Phergus commented Nov 12, 2019

Secondary request for macro function support as well.

@cwisniew cwisniew mentioned this issue Feb 4, 2020
Merged
@cwisniew
Copy link
Member

cwisniew commented Feb 4, 2020 •
edited
Loading

Added menu and following macro commands (PR #1241)

  • showTextLabels() shows the map text labels.
  • hideTextLabels() hides the map text labels.
  • getTextLabelStatus() returns "show" or "hide".

@cwisniew cwisniew self-assigned this Feb 4, 2020
@Phergus Phergus added documentation needed Missing, out-of-date or bad documentation macro changes This issue adds or changes macro functions. Extra work is required (testing, wiki, code editor) labels Feb 4, 2020
@Azhrei
Copy link
Member

Azhrei commented Feb 4, 2020

Is it better to have show/hide functions or a single set function that takes a Boolean? The latter seems better to me as it’s more flexible for scripting (no IF conditional needed to determine which function to call)...

@cwisniew
Copy link
Member

cwisniew commented Feb 4, 2020

I thought about it but in this case I felt this was clearer. Due to lack of real Boolean type you would really need the if anyway. At least this is clearer than showTextLabel(1 or 0)

@Phergus
Copy link
Contributor Author

Phergus commented Feb 6, 2020

Menu option and macro functions working as described.

@Phergus Phergus added tested This issue has been QA tested by someone other than the developer. and removed documentation needed Missing, out-of-date or bad documentation labels Feb 6, 2020
@Phergus
Copy link
Contributor Author

Phergus commented Feb 6, 2020

Wiki updates for menu and new pages added:

@Phergus Phergus closed this as completed Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cwisniew cwisniew

Labels
feature Adding functionality that adds value macro changes This issue adds or changes macro functions. Extra work is required (testing, wiki, code editor) tested This issue has been QA tested by someone other than the developer.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cwisniew @Azhrei @Phergus