Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] bstrlib.h not put in includes directory from 5.4.0 #661

Open
connorjward opened this issue Jan 29, 2025 · 2 comments
Open

[BUG] bstrlib.h not put in includes directory from 5.4.0 #661

connorjward opened this issue Jan 29, 2025 · 2 comments
Labels

Comments

@connorjward
Copy link

Describe the bug
The bstrlib.h file is not put into <prefix>/include for likwid versions 5.4.0+

This is causing pylikwid to not build as it cannot find the bdata macro.

To Reproduce

  1. Download and unpack likwid-5.3.0.tar.gz and likwid-5.4.0.tar.gz
  2. For each run make && sudo make install (setting the prefix so they install somewhere unique).
  3. ls <prefix>/include gives
bstrlib.h  likwid.h  likwid-marker.h

for 5.3.0, but

likwid.h  likwid-marker.h

for 5.4.0. I have verified that this issue persists for 5.4.1 also.

Additional context

Running on Arch Linux

@TomTheBear
Copy link
Member

TomTheBear commented Jan 29, 2025

We published a patch for 5.4.0 on the release page (https://github.com/RRZE-HPC/likwid/releases/tag/v5.4.0). It should be fixed in 5.4.1 but, I have to admit, I did not test pylikwid with it.

I'm on vacation and will not be able to fix anything for the next weeks.

But the fix is more likely required on the pylikwid side. It assumes that the affinity group tag is a bstring and thus uses bdata(). This was changed in 5.4+ to be a character array.

@connorjward
Copy link
Author

Thanks. I have also opened a pylikwid issue discussing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants