Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gelbooru bridge double encodes URLs #1261

Closed
ghost opened this issue Aug 17, 2019 · 0 comments · Fixed by #1262
Closed

Gelbooru bridge double encodes URLs #1261

ghost opened this issue Aug 17, 2019 · 0 comments · Fixed by #1262
Labels
Bug-Report Confirmed bug report

Comments

@ghost
Copy link

ghost commented Aug 17, 2019

Using the Gelbooru bridge, the generated (Atom, JSON, Mrss, plaintext) feeds contain double encoded URLs for tags.

Example:

<entry>
		<title type="html">Gelbooru | 4874400</title>
		<published>2019-08-17T12:02:28+00:00</published>
		<updated>2019-08-17T12:02:28+00:00</updated>
		<id>http://gelbooru.com/index.php?page=post&amp;amp;s=view&amp;amp;id=4874400&amp;tags=1girl</id>
		<link rel="alternate" type="text/html" href="http://gelbooru.com/index.php?page=post&amp;amp;s=view&amp;amp;id=4874400&amp;tags=1girl"/>
		
		<content type="html">&lt;a href="http://gelbooru.com/index.php?page=post&amp;amp;s=view&amp;amp;id=4874400&amp;tags=1girl"&gt;&lt;img src="https://gelbooru.com/thumbnails/f3/4e/thumbnail_f34e6e5bf0a3e9e84a326cccba6b0e65.jpg" /&gt;&lt;/a&gt;&lt;br&gt;Tags:  1girl bangs bare_shoulders black_sailor_collar blonde_hair blouse blue_background blush breasts collarbone commentary_request earmuffs eyebrows_visible_through_hair gradient gradient_background hair_between_eyes looking_at_viewer medium_breasts neck_ribbon open_mouth petals pointy_hair purple_neckwear purple_ribbon ribbon sailor_collar short_hair sleeveless sleeveless_blouse smile solo syuri22 touhou toyosatomimi_no_miko upper_body white_background yellow_eyes </content>
	</entry>

To Reproduce
Steps to reproduce the behavior:

  1. Activate the Gelbooru bridge.
  2. Create any feed (e.g. page 1, tag '1girl').
  3. Select "Atom" as format.
  4. Inspect the contents of the first s "id".

Expected behavior
The 's id contains a valid URL, encoded for XML.
Query parameters are encoded as

&amp;key=value

, not as

&amp;amp;key=value

when inspecting the file in a text editor.

Desktop (please complete the following information):

  • OS: ubuntu 18.04 LTS
  • PHP Version 7.3.8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug-Report Confirmed bug report
Projects
None yet
Development

Successfully merging a pull request may close this issue.

0 participants