Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GithubIssueBridge issue comments, Call to a member function getAttribute() on null on some issues #1267

Closed
TReKiE opened this issue Aug 20, 2019 · 7 comments

Comments

@TReKiE
Copy link
Contributor

TReKiE commented Aug 20, 2019

GithubIssueBridge is failing for certain issue comments with Call to a member function getAttribute() on null.

For example for the issue:
microsoft/terminal#1043
Bridge encountered an unexpected situation! (18128)
Github Issue microsoft/terminal #1043 was unable to receive or process the remote website's content!
Error message: Call to a member function getAttribute() on null
Query string: action=display&bridge=GithubIssue&context=Issue+comments&i=1043&u=microsoft&p=terminal&format=Atom
Version: 2019-07-06

or
microsoft/terminal#766
Bridge encountered an unexpected situation! (18128)
Github Issue microsoft/terminal #766 was unable to receive or process the remote website's content!
Error message: Call to a member function getAttribute() on null
Query string: action=display&bridge=GithubIssue&context=Issue+comments&i=766&u=microsoft&p=terminal&format=Atom
Version: 2019-07-06

but other issues from the same repo are fine, ex. microsoft/terminal#2449
?action=display&bridge=GithubIssue&context=Issue+comments&i=2449&u=microsoft&p=terminal&format=Atom

In addition, if you use the project issues part of the bridge, instead of issue comments, and elect to include the Issue comments in the options, it also fails the same.
Ex. ?action=display&bridge=GithubIssue&context=Project+Issues&u=microsoft&p=terminal&format=Atom will work
but ?action=display&bridge=GithubIssue&context=Project+Issues&c=on&u=microsoft&p=terminal&format=Atom will yield the same Call to a member function getAttribute() on null error.

@Roliga
Copy link
Contributor

Roliga commented Aug 20, 2019

Looks like it doesn't like issues with references in the timeline. Now that you referenced microsoft/terminal#2449 that one doesn't work either.

@Pimmetje
Copy link

Pimmetje commented Oct 1, 2019

Github Issues comments for robgonnella/ardi was unable to receive or process the remote website's content!
 Error message: `Call to a member function getAttribute() on null`
 Query string: `action=display&bridge=GithubIssue&context=Project+Issues&c=on&u=robgonnella&p=ardi&format=Atom`
 Version: `dev.2019-07-06`

@TReKiE
Copy link
Contributor Author

TReKiE commented Oct 2, 2019

@Pimmetje This is by no means a great fix, but to get things working again, I edited bridges\GithubIssueBridge.php, removed line 142 [id^="ref-"], as well as the comma on the prior line.

@Pimmetje
Copy link

Pimmetje commented Oct 2, 2019

Seems to work for now :) Thanks for the workaround :)

@TehPeGaSuS
Copy link

TehPeGaSuS commented Feb 9, 2020

Issue exists in latest git as per today. the fix suggested by @TReKiE doesn't solve it.

Current error:

Bridge encountered an unexpected situation! (18301)
Github Issues comments for inspircd/inspircd was unable to receive or process the remote website's content!
Error message: `Call to a member function getAttribute() on null`
Query string: `action=display&bridge=GithubIssue&context=Project+Issues&c=on&u=inspircd&p=inspircd&format=Html`
Version: `git.master.e5303ef`

Press Return to check your input parameters
Press F5 to retry
Check if this issue was already reported on GitHub (give it a thumbs-up)
Open a GitHub Issue if this error persists

Unticking the Show Issues Comments return the title without any errors.

This only happens when using Project Issues and ticking Show Issues Comments.
When using Issue comments and specifying Issue number, User name and Project name the feed from the issue is displayed properly.

Any suggestions in how to fix this?

@pmaziere
Copy link
Contributor

pmaziere commented Feb 9, 2020

I have sent a request pull here: #1444
It should fix all these issues which are related to changes in github page layout

Up to now it works fine for me, but if you could test it and vote for it, it may accelerate its merge

@TReKiE
Copy link
Contributor Author

TReKiE commented Apr 2, 2020

This particular issue fixed in 2020-02-26 release.

@TReKiE TReKiE closed this as completed Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants