Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DealabsBridge - HotUKDealsBridge - MydealsBridge] Seeking for bridge Parameter advices #2067

Closed
sysadminstory opened this issue Apr 12, 2021 · 3 comments

Comments

@sysadminstory
Copy link
Contributor

sysadminstory commented Apr 12, 2021

Hello !

I open this issue to ask advices about Bridge parameters.

I collected all "groups" of Dealabs, HotUKDeals and Mydeals. Here are the number of groups that was collected (and that could be used in the "group" parameter of those bridges) :

  1758 DealabsBridge.csv
  3119 HotUKDealsBridge.csv
  1922 MydealsBridge.csv

Because of the huge number of "groups" for every bridge, I think it could :

  • slow down the browser to handle such a huge <select> element
  • slow down the generation of the home page

What is the best solution according to you :

  • Keep the "group" parameter as "list" and integrate all the groups ?
  • Change the "group" parameter as text, and ask the user to enter the end of the group URL ?

Thanks in advance for any advice !

@sysadminstory sysadminstory added the Bug-Report Confirmed bug report label Apr 12, 2021
@em92
Copy link
Contributor

em92 commented Apr 13, 2021

Not a user of those bridges. For suggestion I would recommend to keep backward compatibility (old urls must work).

If you need to implement something that could break backward compatibility, consider to make new context with its own parameters.

@em92 em92 removed the Bug-Report Confirmed bug report label Apr 13, 2021
@sysadminstory
Copy link
Contributor Author

Switching the list to a text parameter would not break existing feeds : the actual list value is what the user will have to enter as the text value.

@sysadminstory
Copy link
Contributor Author

I decided to give it a try with the update of the existing list in the pull request #2083 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants