Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heroku Deployment Issue #2688

Closed
LaOrhyUAcMji opened this issue Apr 26, 2022 · 5 comments
Closed

Heroku Deployment Issue #2688

LaOrhyUAcMji opened this issue Apr 26, 2022 · 5 comments
Labels
Bug-Report Confirmed bug report wontfix Indicates that work won't continue on an issue or pull request

Comments

@LaOrhyUAcMji
Copy link

Error when attempting to deploy RSS Bridge in a Heroku app.

To Reproduce
Using https://heroku.com/deploy?template=https://github.com/RSS-Bridge/rss-bridge as mentioned in documentation

Expected behavior
It should deploy RSS Bridge as a Heroku app

Screenshots
image

Desktop (please complete the following information):

  • OS: Win10
  • Browser: Chrome
@LaOrhyUAcMji LaOrhyUAcMji added the Bug-Report Confirmed bug report label Apr 26, 2022
@Bockiii
Copy link
Contributor

Bockiii commented Apr 26, 2022

Is there more log?

@dvikan
Copy link
Contributor

dvikan commented Apr 26, 2022

The repo is blacklisted for some reason.

This worked successfully:

diff --git a/app.json b/app.json                                                                          
index f184799..216a4b7 100644                                                                             
--- a/app.json                                                                                            
+++ b/app.json                                                                                            
@@ -2,7 +2,7 @@                                                                                           
   "service": "Heroku",                                                                                   
   "name": "RSS-Bridge",                                                                                  
   "description": "RSS-Bridge is a PHP project capable of generating RSS and Atom feeds for websites which don't have one.",
-  "repository": "https://github.com/RSS-Bridge/rss-bridge",                                              
+  "repository": "https://github.com/dvikan/rss-bridge",                                                  
   "keywords": ["php", "rss-bridge", "rss"]                                                               
 } 

@Bockiii
Copy link
Contributor

Bockiii commented Apr 26, 2022

XXII. Access a third-party web property for the purposes of web scraping, web crawling, web monitoring, or other similar activity through a web client that does not take commercially reasonable efforts to identify itself via a unique User Agent string describing the purpose of the web client and obey the robots exclusion standard (also known as the robots.txt standard), including the crawl-delay directive;

Well, they are sort-of-right ;)

So yeah.. the easiest would be to fork the repo and then deploy the heroku service from there. Button should stay the same.

@dvikan
Copy link
Contributor

dvikan commented Apr 27, 2022

It's not enough to fork the repo bockiii. I tested with a fork. It was also necessary to apply the diff I pasted above.

@Bockiii
Copy link
Contributor

Bockiii commented Apr 27, 2022

you're right, I implied that.

So in order for the heroku deployment to work, the app.json needs to aim at a repo that is not blacklisted, which should be any fork that is not the main repo.

So, I would close this. It wont help to appeal to heroku since we are doing exactly what they do not want (scraping, ignoring robots.txt etc).

@Bockiii Bockiii closed this as completed Apr 27, 2022
@Bockiii Bockiii added the wontfix Indicates that work won't continue on an issue or pull request label Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug-Report Confirmed bug report wontfix Indicates that work won't continue on an issue or pull request
Projects
None yet
Development

No branches or pull requests

3 participants