Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video embeds for reddit feed (with implementation examples included) #3817

Closed
zinklog2 opened this issue Dec 4, 2023 · 6 comments · Fixed by #4380
Closed

Video embeds for reddit feed (with implementation examples included) #3817

zinklog2 opened this issue Dec 4, 2023 · 6 comments · Fixed by #4380
Labels
Feature-Request Issue is a feature request

Comments

@zinklog2
Copy link

zinklog2 commented Dec 4, 2023

This has become my only way to consume reddit content and I'm very grateful.

If it's possible to add video embeds into the RSS feed itself that'll be amazing. Doing some research on it I've found some repos that are capable of performing this but are either self-hosted or has some problem in another way. Here are those:

https://github.com/trashhalo/reddit-rss
https://github.com/aledeg/xExtension-RedditImage
https://stackoverflow.com/questions/64546615/embed-reddit-video-with-sound

If the logic from these can be implemented here that'll be great.

@zinklog2 zinklog2 added the Feature-Request Issue is a feature request label Dec 4, 2023
@dvikan
Copy link
Contributor

dvikan commented Dec 29, 2023

please produce an example url to an rssbridge instance where you want this to work.

@dvikan
Copy link
Contributor

dvikan commented Dec 29, 2023

@Leomaradan videos are typically available via iframes? looks like iframe tags have always been disallowed by rssbridge?

we could not escape iframe but downside is privacy issues.

@zinklog2
Copy link
Author

Hi, sorry for not checking in since I wasn't sure this is even possible in rss but looking at how flawless youtube videos embed I thought I should look into this again.

https://rss-bridge.sans-nuage.fr/?action=display&bridge=RedditBridge&context=single&r=interestingasfuck&f=&score=5000&d=hot&search=&format=Atom

Here's an example url that fetches the r/interestingasfuck posts that have atleast 5k upvotes, it's a mixture of images and videos, with videos you only getting a thumbnail and a hyperlink to go to the original thread.

@dvikan
Copy link
Contributor

dvikan commented Jan 2, 2025

I fixed so that video works. But still remains to fix audio.

@zinklog2
Copy link
Author

zinklog2 commented Jan 2, 2025

oh wow thanks a lot for this! Do I need to update urls or do something on my end or just wait for the instance owner to update?

@dvikan
Copy link
Contributor

dvikan commented Jan 3, 2025

wait for instance owner update to updates yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature-Request Issue is a feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants