Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dark mode #12

Merged
merged 7 commits into from
May 26, 2024
Merged

feat: dark mode #12

merged 7 commits into from
May 26, 2024

Conversation

hyoban
Copy link
Member

@hyoban hyoban commented May 25, 2024

Supporting dark mode earlier can reduce the pain of late-stage adaptation and prevent us from writing hard-coded colors.

The colors of some locations may still need to be adjusted later.

ScreenShot 2024-05-25 23 57 42
ScreenShot 2024-05-25 23 58 28
ScreenShot 2024-05-26 00 03 23
ScreenShot 2024-05-25 23 59 14

@DIYgod
Copy link
Member

DIYgod commented May 25, 2024

I think it's unnecessary to place the toggle button in such a valuable position on the homepage; putting it in Settings -> General might be a better approach.

@hyoban
Copy link
Member Author

hyoban commented May 26, 2024

Moved to settings page

image

@DIYgod DIYgod merged commit b102807 into RSSNext:main May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants