-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: optimze ui in dark mode, add color themes, replace dark mode impl, add debug inspector #31
Conversation
Signed-off-by: Innei <i@innei.in>
Signed-off-by: Innei <i@innei.in>
Signed-off-by: Innei <i@innei.in>
|
After customizing atomDark's configuration in the case of multiple windows, there may be issues in multiple windows |
@hyoban Maybe there are some bugs in the color transition. CleanShot.2024-06-03.at.4.29.06.mp4 |
@hyoban This way is possible, maybe there is a problem with the css injection script provided by jotai-dark
|
Signed-off-by: Innei <i@innei.in>
Signed-off-by: Innei <i@innei.in>
Signed-off-by: Innei <i@innei.in>
<HeaderActionButton | ||
tooltip={unreadOnly ? "Unread Only" : "All"} | ||
onClick={() => setUnreadOnly(!unreadOnly)} | ||
active={unreadOnly} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The active status may no longer be necessary since the icon already indicates it. Additionally, the style of the active state feels somewhat discordant, I preferred the previous rounded
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I feel like this button is a bit big, what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if it would be better to unify the style of HeaderActionButton.
@@ -27,7 +24,6 @@ export function Component() { | |||
<div | |||
className={cn( | |||
"h-full shrink-0 overflow-y-auto border-r", | |||
window.electron ? "pt-10" : "pt-4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's too tight here, it's better to keep a little padding
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure, but you can try to improve it. I can merge this PR first since it includes other modifications.
return ( | ||
<div className="flex items-center justify-between gap-4"> | ||
{/* TODO system color mode */} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Innei <i@innei.in>
Signed-off-by: Innei i@innei.in
Main Changes
For DX