Allow existing string property to be discriminant #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thx for the PR. Doesnt this break serialization with the JsonInheritanceConverter or just ignore the property? Or what exactly is the purpose of this? Reading the discriminator for deserialized objects? Customizing it will probably not work... |
Exactly.
Hm. Yeah, I actually missed that, since I mostly cared about deserialization. Will update PR with fix. |
|
BTW: You can just update your branch, no need to create a new PR |
|
sure :) Updated PR. Along with serialization fix, added several tests for JsonInheritanceConverter. |
|
Thanks for the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #686
Previously it was not possible to have existing property as discriminant.
With this PR it is allowed if this property is with string type.