Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend cmdlet Set-IshLovValue to update properties one-by-one #101

Open
2 tasks
ddemeyer opened this issue Jun 8, 2020 · 0 comments
Open
2 tasks

Extend cmdlet Set-IshLovValue to update properties one-by-one #101

ddemeyer opened this issue Jun 8, 2020 · 0 comments

Comments

@ddemeyer
Copy link
Contributor

ddemeyer commented Jun 8, 2020

Originally ISHRemote was a thin layer on top of the API, so implementation of Set-IshLovValue was over IshSession.ListOfValues25.UpdateValue(LovId, LovValueId, Label, Description, Active); in turn forcing all properties as mandatory on the cmdlet.

Since the introduction of Active/Inactive in the user interfaces since 14SP1/14.0.1 the toggling of Active to Inactive is more important.

Best implementation is

  • Make parameters optional, also extra Pester tests
  • When not all parameters are specified, add a Get operation to default the missing properties in the UpdateValue API call

Other considered options are

  • Extend Set-IshMetadataField to overwrite “fields” of LovValue objects…
    Get-IshLovValue … | Set-IshMetadataField -Active $False | Set-IshLovValue
  • Or await a better API call :-)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant