New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Model properties mapped with _self cause unnecessary link resolver round trip #112

Open

willprice76 opened this issue Aug 23, 2018 · 0 comments

Labels

Contributor

willprice76 commented Aug 23, 2018

In the GenericSemanticModelDataConverter.selfLink method there is always a round trip to the link resolver to resolve the link:
https://github.com/sdl/dxa-web-application-java/blob/58a4fdebafc192b9a87570c684bd97d9091fdc5f/dxa-framework/dxa-tridion-provider/src/main/java/com/sdl/dxa/tridion/mapping/converter/GenericSemanticModelDataConverter.java#L83
This can be unnecessary as:

If you want to convert to an EntityModel, you don't use the link URL
Using the DXA 2.0 model service there should already be a resolved link URL in the EntityModelData (check .getLinkUrl())

This will cause performance problems on pages containing many component presentations, which map to models with a _self SemanticProperty annotation.

rpannekoek added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment