Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Tests fail for some models #781

Closed
DaJansenGit opened this issue Oct 14, 2019 · 4 comments
Closed

CI Tests fail for some models #781

DaJansenGit opened this issue Oct 14, 2019 · 4 comments
Labels
CI All issues related to Continuous Integration

Comments

@DaJansenGit
Copy link
Member

DaJansenGit commented Oct 14, 2019

Some tests currently fail after the newest IBPSA merge, like here due to divation from reference results.

First @MichaMans and me thought this was due to the update from reference results in the IBPSA to dymola 2020

But even after using the dymola 2020 container the deviation changes but is still there, this can be seen here

I simulated one of the failing thermalzone examples locally, both with dymola 2020 and the deviation is still there, I used the same solver with same tolerances. The screenshot shows the timestamp with the highest deviation recording to the regression test.

image

@MichaMans @PMehrfeld do you have any idea where this deviation comes from?

@PMehrfeld PMehrfeld mentioned this issue Oct 14, 2019
8 tasks
@DaJansenGit DaJansenGit added the CI All issues related to Continuous Integration label Oct 15, 2019
@MichaMans
Copy link
Contributor

@DaJansenGit I have no idea where the deviations come from. The marked area/time at comparison is the time with the highest deviation? If so, we should maybe check:

  • if we are still in the VDI 6007 deviation range
  • why the check does not fail in the ibpsa --> open a discussion branch there?
  • check again if the reference results from the ibpsa and our are 100% the same

@DaJansenGit
Copy link
Member Author

I updated the screenshot, it shows now the timestamp of the highest deviation.

  • I will check the VDI6007 range
  • I will open an discussion branch in IBPSA
  • the reference results are 100 % the same, I checked this already

@mlauster
Copy link
Contributor

mlauster commented Oct 15, 2019

I can't check your example results, since they are not accessible for external, but the VDI range is 0.1 K for hourly means.

@DaJansenGit
Copy link
Member Author

DaJansenGit commented Nov 8, 2019

We solved this issue with:

  • a new merge of the current master
  • the usage of dymola 2020 container
  • the creation of a new CI runner server with better performance

Thanks for you effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI All issues related to Continuous Integration
Projects
None yet
Development

No branches or pull requests

3 participants