Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed incorrect link in notebook #1426

Merged
merged 4 commits into from
Jun 21, 2017
Merged

Fixed incorrect link in notebook #1426

merged 4 commits into from
Jun 21, 2017

Conversation

aneesh-joshi
Copy link
Contributor

Fixed the link to unsupervised learning in the gensim quick start notebook simply by removing ".html" from the end.
I know this is a small contribution and rather stupid, but it is my first contribution.
If not deemed worthy of a PR please close it.

I have pushed to the develop branch. Is that ok?

Note:
I had made a commit before this but that one caused some unnecessary changes in the notebook like python versions.
so I git stashed that version, then reset it and pushed and made this PR.

@aneesh-joshi
Copy link
Contributor Author

also,
should such small changes be put as a PR or added as an issue?

@@ -0,0 +1,389 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove .ipynb_checkpoints/*

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not understand what you mean by this.
I searched my repo for ".ipynb_checkpoints/*" but couldn't find a single match.
Perhaps you are looking at an old commit.

I opened the ipython notebook initally on my computer which might have caused these changes.

Is there any way to edit notebooks without affecting default settings?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.ipynb_checkpoints/gensim Quick Start-checkpoint.ipynb - you need to remove this file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Removed it and committed!
Thanks for you kindness!
will move on to more difficult a task.
Speaking of which, could you please review the issue :
#1419

It is about a word embedding visualiser that I have implemented.

@@ -56,7 +56,7 @@
"source": [
"## Accessing the `gensim` Jupyter notebooks\n",
"\n",
"All of the `gensim` tutorials (including this document) are stored in [Jupyter notebooks](http://jupyter-notebook-beginner-guide.readthedocs.io/en/latest/what_is_jupyter.html). These notebooks allow the user to run the code locally while working through the material. If you would like to run a tutorial locally, first clone the GitHub repository for the project.\n",
"All of the `gensim` tutorials (including this document) are stored in [Jupyter notebooks](http://jupyter-notebook-beginner-guide.readthedocs.io/en/latest/what_is_jupyter). These notebooks allow the user to run the code locally while working through the material. If you would like to run a tutorial locally, first clone the GitHub repository for the project.\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect, It's a broken link.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah
Accidentally removed the .html from this link instead of the unsupervised learning link

@menshikh-iv
Copy link
Contributor

@aneesh-joshi Do not worry that your PR is small, it's your first step in open-source world 👍
Please correct your PR according with my comments and I will merge it.

@menshikh-iv
Copy link
Contributor

Congratulations on your first PR @aneesh-joshi 🥇

@menshikh-iv menshikh-iv merged commit a2b6b32 into piskvorky:develop Jun 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants