Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve KeyedVector.wmdistance #2326

Merged
merged 2 commits into from
Jan 11, 2019
Merged

Improve KeyedVector.wmdistance #2326

merged 2 commits into from
Jan 11, 2019

Conversation

horpto
Copy link
Contributor

@horpto horpto commented Jan 10, 2019 •
edited
Loading

  • bring out check on docset1 from inner cycle
  • use symmetry of the metric to reduce calculations (actually in original code distance_matrix was not symmetrical sometimes although it should be by definition; pyemd forgives this)

@menshikh-iv menshikh-iv changed the title Improve wmdistance Improve KeyedVector.wmdistance Jan 10, 2019
@menshikh-iv
Copy link
Contributor

Thank you @horpto, you are top commiter in release ⭐

@menshikh-iv menshikh-iv merged commit 3a7760a into piskvorky:develop Jan 11, 2019
@horpto horpto deleted the wmdistance branch January 19, 2019 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@horpto @menshikh-iv