Detect when a fasttext executable is available in PATH #3264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #3264 +/- ##
========================================
Coverage 79.53% 79.53%
========================================
Files 68 68
Lines 11781 11781
========================================
Hits 9370 9370
Misses 2411 2411 Continue to review full report at Codecov.
|
Also check that fasttext exists in FT_HOME and is executable. This is useful when using a distro like Debian that has a package of fasttext available to install.
pabs3
force-pushed
the
detect-fasttext-in-PATH
branch
from
1dd8f7e to
0b59ffe
Compare
|
Can someone re-run the checks? Seems like they timed out. |
|
@piskvorky I'm going to merge this as-is because we use the facebook executable in multiple places during the tests. It's easier to use the executable than to store half a dozen models as test data. |
|
@pabs3 Thank you for your work! |
piskvorky
reviewed
Feb 26, 2022
| @@ -44,7 +45,8 @@ | |||
| BUCKET = 10000 | |||
|
|
|||
| FT_HOME = os.environ.get("FT_HOME") | |||
| FT_CMD = os.path.join(FT_HOME, "fasttext") if FT_HOME else None | |||
| FT_CMD = shutil.which("fasttext", path=FT_HOME) or \ | |||
pabs3
added a commit
to pabs3/gensim
that referenced
this pull request
Feb 26, 2022
Requested-in: piskvorky#3264 (review)
mpenkov
added a commit
that referenced
this pull request
Mar 20, 2022
Requested-in: #3264 (review) Co-authored-by: Michael Penkov <m@penkov.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also check that fasttext exists in FT_HOME and is executable.
This is useful when using a distro like Debian that
has a package of fasttext available to install.