-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typos, text and code fix in LDA tutorial #3289
Typos, text and code fix in LDA tutorial #3289
Conversation
Is this a part of some assignment? |
@piskvorky, no, I was just reading the tutorial and found some errors. Just a free contribution. |
@piskvorky First, enable logging (as described in many Gensim tutorials), and set eval_every = 1 in LdaModel I've tried Googling it using the doc search bar (that is a never-ending search BTW) and could not find a working example in less time than it would require to just describe the complete solution in the tutorial. So I propose to simply add the proper way to set the logger ( |
Yeah, that phrase Can you include this code in its place instead? logging.basicConfig(level=logging.INFO, format='PID:%(process)d:%(threadName)s - %(asctime)s - %(levelname)s - %(filename)s:%(lineno)s - %(message)s') Thanks! |
Fixed in 00b54dc |
LGTM, thanks! The failing wheels seem unrelated, @mpenkov is working on those. |
@piskvorky glad to help! |
Codecov Report
@@ Coverage Diff @@
## develop #3289 +/- ##
========================================
Coverage 79.53% 79.53%
========================================
Files 68 68
Lines 11781 11783 +2
========================================
+ Hits 9370 9372 +2
Misses 2411 2411
Continue to review full report at Codecov.
|
Merged, thanks @davebulaval ! |
This PR fixes the following in all three files format:
os.path
andio
)Moreover, the following link is broken http://rare-technologies.com/lda-training-tips/, and I was not able to find the new URL.