[WIP] DTM Tutorial Notebook and changes #831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 19, 2016
| """ | ||
|
|
||
| doc_topic = numpy.copy(self.gammas) | ||
| doc_topic /= doc_topic.sum(axis=1)[:, numpy.newaxis] |
There was a problem hiding this comment.
Why not simply self.gammas / self.gammas.sum(axis=1)[:, numpy.newaxis]? Are you running out of memory?
If so, put a clear comment to that effect here, so somebody doesn't accidentally "fix" the code later.
|
@piskvorky could you review the rest of the code as well? I'm guessing there will be other performance/style issues which I might have missed out on and would be good to address all of it at once. I've also updated the notebook, so would be awesome if you could have a look at that as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will work on updated Tutorial notebook here, and make changes to
ldaseqmodel.First step I've done is to completely remove the
seq_corpusclass, to make it easier to get a constant memory footprint.