Resolve Issue #145, add warnings for Issue #146 #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piskvorky
requested changes
Nov 24, 2017
smart_open/smart_open_lib.py
Outdated
| @@ -157,20 +168,26 @@ def smart_open(uri, mode="rb", **kw): | |||
| elif parsed_uri.scheme in ("s3", "s3n", 's3u'): | |||
| return s3_open_uri(parsed_uri, mode, **kw) | |||
| elif parsed_uri.scheme in ("hdfs", ): | |||
| if kw.get('encoding') is not None: | |||
| warnings.warn('Issue #146: encoding is not supported for HDFS, ignoring') | |||
There was a problem hiding this comment.
Let's be a little more verbose. Why is it not supported -- is it a fault of the user, or a functionality gap in smart_open? What can the user do about this? (how to fix the warning?)
The issue number is too obscure too. If it's really relevant, we should quote it directly in the message, or at least provide a link. Conveying information to users in this way is too complicated.
There was a problem hiding this comment.
OK, done. Please have a look.
menshikh-iv
changed the title
|
Thank you @mpenkov 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 145: Added tests for reading and writing encoded text files on S3. Originally planned to add the same tests for the other subsystems (HDFS, WebHDFS, HTTP), but discovered that encoding is not handled at all there (it is ignored).
Issue 146: added warnings for cases where the encoding is specified and quietly ignored.