Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve S3 read performance. Fix #152 #157

Merged
merged 2 commits into from
Dec 6, 2017
Merged

Improve S3 read performance. Fix #152 #157

merged 2 commits into from
Dec 6, 2017

Conversation

mpenkov
Copy link
Collaborator

@mpenkov mpenkov commented Dec 6, 2017

This PR improves the speed of reading from S3. It fixes #152 (performance regression from release 1.5.4).

The previous implementation performed a .get every time when reading to
the buffer.  This was wasteful and unnecessary.  A single .get is
sufficient to read from the current position until the end of the file.
Another .get is only necessary when seeking.
This matches the behavior of 1.5.3 more closely, as observed during live
tests against S3.
@piskvorky piskvorky changed the title Resolve issue #152 Improve S3 read performance Dec 6, 2017
@menshikh-iv menshikh-iv changed the title Improve S3 read performance Improve S3 read performance. Fix #152 Dec 6, 2017
@menshikh-iv menshikh-iv merged commit fbc82cc into piskvorky:master Dec 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reading S3 files becomes slow after 1.5.4
2 participants