-
-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding streaming http support. #236
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @handsomezebra, please work on testing now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, the code looks very good.
I think we need more tests, especially unit tests for the new SeekableBufferedInputBase class. Seek logic can be tricky, and having tests will insure us against logic bugs in that functionality.
ping @handsomezebra, are you planning to finish PR? |
Still need to add tests. |
@handsomezebra I cleaned up your commit for you, added some tests, and merged this in. Congrats on your first PR to smart_open 🚀 |
This pack adds the streaming support for http.
The responses lib doesn't support mock of streaming http so I didn't have a good way to unit test it. Any suggestions?